feat(function-aws-api-proxy): add multipart/form-data support to ApiGatewayServletRequest #2317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atewayServletRequest This adds support for parsing multipart/form-data in AWS API Gateway proxy requests. The implementation handles boundary extraction, part parsing, and field name extraction while maintaining compatibility with existing form handling. Co-Authored-By: Claude <[email protected]>
|
|
|
Nice! Will review next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! This is a change to add support for multipart form uploads, e.g. file uploads. The
Serverless Functionmode already supports file uploads, but if you want to use them in your controllers (Applicationmode), we need something like this.Previously, this module was using the query string decoder on the body for multipart uploads, which isn't right -- multipart form bodies have their own crazy syntax.
This adds support to the base ApiGatewayServletRequest for multipart/form-data requests and argument bindings for:
@Part String name(binding to a part of namename)@Part("foo") String name@Part("file") CompletedFileUpload fileThis does NOT add support for:
This change is currently missing:
I've created a simple test project that can verify this works and can provide if there's interest.
Looking for feedback and direction on things that need to be implemented before this can be merged. Thanks!
Closes #270.