Handle RuntimeException when getting/setting JMS headers #5746
+13
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you for the PR!
I'm thinking about the consequences of doing this: since this can happen if a propagation format that contains - is used, this can hide the underlying problem and propagation still won't work.
I'm wondering if we should log a warning (maybe a warning first then debug using WarnThenDebugLogger). What do you think?
cfredri4
force-pushed
the
handle-runtime-exception-when-getting-setting-jms-headers
branch
from
f007427 to
d8fbfc7
Compare
|
Good idea. Pushed fix. |
jonatan-ivanov
requested changes
Dec 18, 2024
...karta9/src/main/java/io/micrometer/jakarta9/instrument/jms/JmsProcessObservationContext.java
Outdated
Show resolved
Hide resolved
...karta9/src/main/java/io/micrometer/jakarta9/instrument/jms/JmsPublishObservationContext.java
Outdated
Show resolved
Hide resolved
...karta9/src/main/java/io/micrometer/jakarta9/instrument/jms/JmsProcessObservationContext.java
Outdated
Show resolved
Hide resolved
jonatan-ivanov
added
bug
|
I think we should do this against |
Currently JMSException is handled when getting/setting JMS headers. Some JMS providers will throw RuntimeException instead of JMSException when failing to get/set JMS headers. This change adds so that all exceptions are handled.
cfredri4
force-pushed
the
handle-runtime-exception-when-getting-setting-jms-headers
branch
from
d8fbfc7 to
0c40732
Compare
|
Pushed fixes. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently JMSException is handled when getting/setting JMS headers. Some JMS providers will throw RuntimeException instead of JMSException when failing to get/set JMS headers. This change adds so that RuntimeException is also handled.
For example, Qpid JMS throws IllegalArgumentException which leads to similar issue as #4202.