-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gradle command #5735
base: main
Are you sure you want to change the base?
Fix gradle command #5735
Conversation
fc6f16b
to
09d8672
Compare
Cannot we "just" upgrade to 7.x instead of using 6.x and 7.x simultaneously? |
7.x requires Java 17, I believe. |
Java 11 is incompatiable with version 7.x. If just upgrade version, I think we will wait until we have a plan not support prior java 17 |
What's remaining to move this PR to ready for review? I ran |
Just to be clear, this will fix it as long as you are running the build with JDK 17 or higher, but the build will still fail with 11. Is that right? |
I have not yet tested on java 11. Could we can check via ci/cd? |
The CI build uses |
bf057fe
to
f1b7793
Compare
I confirm it works on java 17 |
Yes, it fixes it when using JDK 17+ with the build, but as far as I could tell |
Related gh-5599
I run
./gradlew :micrometer-osgi-test:check
and the result is success on my local machine with OS is Windows 11.I think we should check
./gradlew clean check
before merging (maybe the result will be different)