Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Theme #13

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Light Theme #13

wants to merge 9 commits into from

Conversation

cbviva
Copy link

@cbviva cbviva commented Dec 15, 2018

No description provided.

@Nanolx
Copy link

Nanolx commented Dec 15, 2018

Two things:

  • a) you broke API 9 compat, so instead of
        <item name="android:windowLightStatusBar">true</item>
        <item name="android:navigationBarColor">@color/color_white</item>

it should be

        <item name="android:windowLightStatusBar" tools:targetApi="23">true</item>
        <item name="android:navigationBarColor" tools:targetApi="21">@color/color_white</item>
  • b) maybe consider using Theme.AppCompat.DayNight so that it auto-switches between Light and Dark theme as per System Settings?

@cbviva
Copy link
Author

cbviva commented Dec 16, 2018

@Nanolx I gonna implement auto-switching in the future

@Nanolx
Copy link

Nanolx commented Dec 25, 2018

For now you'd also need a commit like this, else the gear/settings icon for nlp backends gets almost invisible: Nanolx/android_packages_apps_UnifiedNlp@482bcef

@Nanolx
Copy link

Nanolx commented Mar 2, 2019

Any news?

@Vavun
Copy link

Vavun commented Mar 28, 2019

It seems he is dead :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants