Improved readme #147
Improved readme #147
Conversation
Merged info for all Android versions to have a global idea Make it usable when the device is inside the recovery or inside the system Added separate adb commands for various Android versions Added info for Oreo Added Déjà Vu Location Service (Based on pull request microg#146 by @David-Guillot)
README.md
Outdated
|
|
||
| 1. Make sure that no Google geolocation tool is installed (it is usually listed as Google Play Services in Apps) | ||
| 2. Download and install `NetworkLocation.apk` as a usual app (you may need to enable "Unknown sources" in Settings->Security) | ||
| 3. Reboot and continue at [Usage](#usage) | ||
|
|
||
| Some ROMs, especially those not based on AOSP might have problems using this method. However, if your system has root, you can try installing the hard way: | ||
| **Important:** Installing as system app will always works, instead installing as user app will only works out of the box on Android versions from 4.4 to 6.x. |
There was a problem hiding this comment.
should be "will only work out of the box" (minus the s)
README.md
Outdated
| @@ -27,7 +27,7 @@ On these systems installation is easy: | |||
| 2. Download and install `NetworkLocation.apk` as a usual app (you may need to enable "Unknown sources" in Settings->Security) | |||
| 3. Reboot and continue at [Usage](#usage) | |||
|
|
|||
| **Important:** Installing as system app will always works, instead installing as user app will only works out of the box on Android versions from 4.4 to 6.x. | |||
| **Important:** Installing as system app will always works, instead installing as user app will only work out of the box on Android versions from 4.4 to 6.x. | |||
There was a problem hiding this comment.
Slightly improve grammar:
Installing as a system app will always work for all versions of Android. But installing as user app will only work on Android versions 4.4 to 6.x.
There was a problem hiding this comment.
I have kept "out of the box" because it means without changes, you can make it working (but not out of the box).
There was a problem hiding this comment.
Also strike the "s" in "will always works" (→ "will always work") :)
There was a problem hiding this comment.
I have already corrected it when I have talked about "out of the box".
|
Looks like you have trouble with the "s". Shouldn't it read
And instead
? 😉 |
Merged info for all Android versions to have a global idea
Make it usable when the device is inside the recovery or inside the system
Added separate adb commands for various Android versions
Added info for Oreo
Added Déjà Vu Location Service
(Based on pull request #146 by @David-Guillot)
This change is