Add IPv6 support to PyGopherd#2
Open
rhymeswithmogul wants to merge 2 commits intomichael-lazar:masterfrom
Open
Add IPv6 support to PyGopherd#2rhymeswithmogul wants to merge 2 commits intomichael-lazar:masterfrom
rhymeswithmogul wants to merge 2 commits intomichael-lazar:masterfrom
Conversation
This commit adds IPv6 support to PyGopherd. Both types of TCP servers will now listen for both IPv4 and IPv6 connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will add dual-stack support to PyGopherd's two TCP servers. The daemon will now listen for both IPv4 and IPv6 connections. I have done limited testing with my Gopher server and found no errors, though I admit I may be the first person in the world to browse Gopher over IPv6!
Many Gopher clients only speak IPv4, so just to make sure, I had to test with Netcat:
which produced a Gopher listing!