Skip to content

Commit

Permalink
code improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
mhogomchungu committed Feb 11, 2025
1 parent f7ecf7a commit 551ac3e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
17 changes: 13 additions & 4 deletions src/batchdownloader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,16 @@ void batchdownloader::gotEvent( const QJsonObject& jsonArgs )
auto autoDownload = jsonArgs.value( "-a" ).toBool() ;
auto showThumbnail = jsonArgs.value( "-e" ).toBool() ;

this->addToList( url,autoDownload,showThumbnail ) ;
auto m = m_showMetaData ;
auto s = m_startAutoDownload ;

m_startAutoDownload = autoDownload ;
m_showMetaData = showThumbnail ;

this->addToList( url ) ;

m_showMetaData = m ;
m_startAutoDownload = s ;
}
}

Expand Down Expand Up @@ -2055,7 +2064,7 @@ void batchdownloader::clipboardData( const QString& url )
if( m_table.rowWithUrl( url ) == -1 ){

m_ui.tabWidget->setCurrentIndex( 1 ) ;
this->addToList( url,false,m_showMetaData ) ;
this->addToList( url ) ;
}
}
}
Expand Down Expand Up @@ -2426,11 +2435,11 @@ void batchdownloader::networkResult( networkCtx d,const utils::network::reply& r
utility::networkReply( this,&batchdownloader::networkData,m_ctx,reply,nullptr,d.index,d.media.move() ) ;
}

void batchdownloader::addToList( const QString& u,bool autoDownload,bool showThumbnails )
void batchdownloader::addToList( const QString& u )
{
const auto& ee = this->defaultEngine() ;

ee.updateVersionInfo( m_ctx,[ this,&ee,u,autoDownload,showThumbnails ](){
ee.updateVersionInfo( m_ctx,[ this,u ](){

Items items ;

Expand Down
2 changes: 1 addition & 1 deletion src/batchdownloader.h
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ private
const engines::engine& defaultEngine() ;
void clearScreen() ;
void showCustomContext() ;
void addToList( const QString&,bool autoDownload = false,bool showThumbnails = true ) ;
void addToList( const QString& ) ;
void download( const engines::engine&,downloadManager::index ) ;
void download( const engines::engine&,Items ) ;
void download( const engines::engine&,int = 0 ) ;
Expand Down

0 comments on commit 551ac3e

Please sign in to comment.