Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebDB #408

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Add WebDB #408

merged 4 commits into from
Nov 7, 2023

Conversation

aleluff
Copy link
Contributor

@aleluff aleluff commented Oct 28, 2023

Requirements for your pull request

  • I have read and understood the contribution.MD file

@mgramin
Copy link
Owner

mgramin commented Oct 30, 2023

Thank you for your contribution.

It would be beneficial to enhance the current description by adding more differentiating factors compared to other IDEs.

@mgramin
Copy link
Owner

mgramin commented Oct 30, 2023

@aleluff Thank you for your PR! Please fix the linter error:

README.md:87:2[9](https://github.com/mgramin/awesome-db-tools/actions/runs/6676891285/job/18184851251?pr=408#step:3:10)
  ✖  87:29  List item description must end with proper punctuation  remark-lint:awesome-list-item

@aleluff
Copy link
Contributor Author

aleluff commented Oct 30, 2023

Done

@aleluff
Copy link
Contributor Author

aleluff commented Nov 7, 2023

Hey,

Can you merge the PR please

@mgramin
Copy link
Owner

mgramin commented Nov 7, 2023

Hey,

Can you merge the PR please

Hi @aleluff ! Sure, could you please provide your response to my previous comment - #408 (comment) ?

Improve description
@aleluff
Copy link
Contributor Author

aleluff commented Nov 7, 2023

I didn't saw it, done

@mgramin
Copy link
Owner

mgramin commented Nov 7, 2023

Thank you @aleluff ! The updated description looks awesome! Could you please fix the linter error and I will merge it without delay

Fix ponctuation
@aleluff
Copy link
Contributor Author

aleluff commented Nov 7, 2023

Finally done

@mgramin mgramin merged commit 22b56ab into mgramin:master Nov 7, 2023
1 check passed
@mgramin
Copy link
Owner

mgramin commented Nov 7, 2023

Merged!😉

@aleluff
Copy link
Contributor Author

aleluff commented Nov 7, 2023

Damm =)

Can you please take minutes to try and give me feedback

@mgramin
Copy link
Owner

mgramin commented Nov 12, 2023

@aleluff, sure, could you please provide me with your email or another contact method where I can leave my feedback?

PS
My email is [email protected]

@aleluff
Copy link
Contributor Author

aleluff commented Nov 12, 2023

Here is my personal : [email protected]

@aleluff
Copy link
Contributor Author

aleluff commented Nov 12, 2023

I'm available for a call if you prefer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants