Do not emit DefaultValueAttribute for xml:lang and xml:space attribut…

…es (see #245)
mganss · Jan 12, 2021 · b918fa9 · b918fa9
1 parent 7412170
commit b918fa9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/XmlSchemaClassGenerator/CodeUtilities.cs b/XmlSchemaClassGenerator/CodeUtilities.cs
@@ -399,5 +399,15 @@ public static CodeTypeReference CreateTypeReference(Type t, GeneratorConfigurati
  else
  return new CodeTypeReference(t, conf.CodeTypeReferenceOptions);
  }
+
+ /// <summary>
+ /// See https://github.com/mganss/XmlSchemaClassGenerator/issues/245
+ /// and https://docs.microsoft.com/en-us/dotnet/api/system.xml.serialization.xmlattributeattribute#remarks
+ /// </summary>
+ public static bool IsXmlLangOrSpace(XmlQualifiedName name)
+ {
+ return name != null && name.Namespace == "http://www.w3.org/XML/1998/namespace"
+ && (name.Name == "lang" || name.Name == "space");
+ }
  }
 }
diff --git a/XmlSchemaClassGenerator/TypeModel.cs b/XmlSchemaClassGenerator/TypeModel.cs
@@ -813,7 +813,8 @@ public void AddInterfaceMembersTo(CodeTypeDeclaration typeDeclaration)
  {
  var defaultValueExpression = propertyType.GetDefaultValueFor(DefaultValue, IsAttribute);
 
- if ((defaultValueExpression is CodePrimitiveExpression) || (defaultValueExpression is CodeFieldReferenceExpression))
+ if ((defaultValueExpression is CodePrimitiveExpression) || (defaultValueExpression is CodeFieldReferenceExpression)
+ && !CodeUtilities.IsXmlLangOrSpace(XmlSchemaName))
  {
  var defaultValueAttribute = CreateDefaultValueAttribute(typeReference, defaultValueExpression);
  member.CustomAttributes.Add(defaultValueAttribute);
@@ -927,7 +928,8 @@ public void AddMembersTo(CodeTypeDeclaration typeDeclaration, bool withDataBindi
 
  member.Name += GetAccessors(member.Name, backingField.Name, propertyType.GetPropertyValueTypeCode(), false, withDataBinding);
 
- if (IsNullable && ((defaultValueExpression is CodePrimitiveExpression) || (defaultValueExpression is CodeFieldReferenceExpression)))
+ if (IsNullable && ((defaultValueExpression is CodePrimitiveExpression) || (defaultValueExpression is CodeFieldReferenceExpression))
+ && !CodeUtilities.IsXmlLangOrSpace(XmlSchemaName))
  {
  var defaultValueAttribute = CreateDefaultValueAttribute(typeReference, defaultValueExpression);
  member.CustomAttributes.Add(defaultValueAttribute);