Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent unnecessary recompilation #402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lzy1g1225
Copy link

@lzy1g1225 lzy1g1225 commented Jun 30, 2020

I found that libtins got recompile everytime which drive me crazy when I switched debug/release mode or when I switched from win32/linux.
The reason is the cmake generates config.h for those build types into source folder and got the config.h overwritten, which causing the compiler to recompile the whole project.
I suggest to generate config.h in binary directory. That make every config.h stay with there own build type.

…he whole project when the build type changed
@lzy1g1225 lzy1g1225 changed the title generate config.h in binary directory generate config.h in binary directory to prevent unnecessary recompilation Jun 30, 2020
@lzy1g1225 lzy1g1225 changed the title generate config.h in binary directory to prevent unnecessary recompilation prevent unnecessary recompilation Jun 30, 2020
@lzy1g1225
Copy link
Author

Looks like the appveyor build check failed because tests and examples didn't update include path for config.h. Will add this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant