Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows winsock2.h include issue by including pcap.h first #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

douglaspeer
Copy link

@douglaspeer douglaspeer commented May 31, 2019

On windows, a project that uses libtins does not build without including pcap.h first. This was first noted with the use of the sniffer class. It might be possible to modify sniffer.h with this change, but this seemed the most likely to handle any future header includes.

@douglaspeer douglaspeer changed the title fix windows winsock2.h include issue by rearranging sniffer.h include fix windows winsock2.h include issue by including pcap.h first Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant