don't pretend to support clojure 1.10 #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/clojure.yml was using $CLOJURE_ALIAS, while bin/kaocha was looking at $CLOJURE
tests weren't passing on 1.10 anyway due to code using clojure.core/random-uuid, introduced in 1.11
opqdonut
changed the title
|
Should we have a (backdated?) changelog entry for dropping 1.10 support? Looks like tests were broken for 1.10 as early as 2022-10, see #767 |
ikitommi
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't really running tests on clojure 1.10 due to a mistake in the CI script (see first commit). Unsurprisingly the tests don't pass on 1.10 due to code using new functions like
random-uuid.Drop the fake 1.10 testing.