Pass function metadata to malli.core/-instrument #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change extends the third arity of malli.core/-instrument so that it optionally accepts the metadata of the old function. That metadata is passed downstream to the `report` function. This new modality is called in malli.instrument so that when we render we can know the name (and the source file location) of the offending function.
opqdonut
requested changes
May 27, 2022
| @@ -23,7 +23,7 @@ | |||
| (true? (:gen d)) (dissoc $ :gen) | |||
| :else $))] | |||
| (alter-meta! v assoc ::original-fn original-fn) | |||
| (alter-var-root v (constantly (m/-instrument dgen original-fn))) | |||
| (alter-var-root v (constantly (m/-instrument dgen original-fn nil :original-fn-meta (meta v)))) | |||
There was a problem hiding this comment.
we discussed this briefly with @ikitommi and we'd prefer if you passed in :meta (meta v) as part of dgen, the first argument of -instrument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends the third arity of
malli.core/-instrumentso that itoptionally accepts the metadata of the old function. That metadata is
passed downstream to the
reportfunction.This new modality is called in
malli.instrument/-strument!so thatwhen we render we can know the name (and the source file location)
of the offending function.