-
Notifications
You must be signed in to change notification settings - Fork 151
Another round of example updates #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
It could be good to check compatibility of these packages to Meteor 3.x and prepare a branch after this one is merged. I don't think we would have incompabilities with packages described here, but it is always good to double check. |
Another issue, you can check my stream where I did some work on that: https://www.youtube.com/watch?v=jzWXxOe93t4 |
Updated examples for Meteor 3. Also updated the camera package as well. |
Also moved to FlowRouter from IronRouter
// Router.configure({ | ||
// layoutTemplate: "layout" | ||
// }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to keep these comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep it commented for at least one more iteration just in case I have missed something in the migration to flow-router.
This is nice to have 🤩. So, do you verify it runtime as well and examples work for Meteor 3? |
Yes, it all runs. I did this on my stream. Part of this also became an update for the camera package to be able to update to Meteor 3. There is another PR as well. Would be nice to get this all in. |
Update all examples including Solomo, to at least Meteor 2.13.3