[3.x] Update Node 20.12.2, Npm 10.5.0 and Typescript 5.4.5 (Dev bundle 20.12.2.0) #13090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v3-meteor-api-docs canceled.
|
|
you need to build a new dev bundle btw |
nachocodoner
changed the title
nachocodoner
changed the title
nachocodoner
changed the title
nachocodoner
changed the title
Grubba27
reviewed
Apr 11, 2024
Grubba27
reviewed
Apr 11, 2024
✅ Deploy Preview for v3-migration-docs canceled.
|
This reverts commit 32e4f38.
|
Node 20.13.0 is out: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSS-386
OSS-385
Fix on Windows tests
After the 18.20.2/20.12.2 node.js updates, calling
spawnwith a .cmd or .bat file requires theshell: trueoption. This PR adjusts our usage accordingly.Update
Tests are fixed on Windows as seen on this picture:
However, it doesn't finish properly reaching this code, and it times out at the end.
And locally, I can't seem to reproduce the same, locally it finishes properly.
Trying to debug the code around spawn of child processes, since maybe one is never stop after last adjusts. But hard to verify it since locally behaves differently.