Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Uncaught TypeError: Cannot convert undefined or null to object in livedata_connection.js #13081

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

mjcctech
Copy link

@mjcctech mjcctech commented Apr 5, 2024

We are using https://github.com/wojtkowiak/meteor-custom-protocol and some messages have null value for msg. Unfortunately code checking this case has a bug and end up with error message in browser console

livedata_connection.js:1780 Uncaught TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at Connection.onMessage (livedata_connection.js:1780:20)
    ...

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@nachocodoner nachocodoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this is ok. I have seen this error on the past and hopefully this covers the fix.

However, since this change impacts the core, I'd appreciate another experienced set of eyes, like @denihs, to review this. Tests are passing, but it's crucial to ensure we haven't missed any scenario with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants