Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --release option info to meteor publish #12956

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

qwertyroop
Copy link

This commit adds documentation for the --release option in the meteor publish
command. The --release option is introduced to help resolve top-level version
conflicts during the package publishing process, especially in scenarios where
packages have conflicting version requirements. Users can now specify the
appropriate release version to satisfy all package version constraints.

Fixes #12954

…tation for the --release option in the meteor publish

command. The --release option is introduced to help resolve top-level version
conflicts during the package publishing process, especially in scenarios where
packages have conflicting version requirements. Users can now specify the
appropriate release version to satisfy all package version constraints.

Fixes meteor#12954
@CLAassistant
Copy link

CLAassistant commented Jan 11, 2024

CLA assistant check
All committers have signed the CLA.

@StorytellerCZ
Copy link
Collaborator

@jankapunkt please check

@@ -914,11 +914,11 @@ Options:
Publish a new version of a package to the package server.

Usage: meteor publish [--create]
meteor publish --update
meteor publish --update [--release <version>]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if --release should be moved to the first example. It's normally used when publishing a new version instead of when updating the metadata.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, especially now, using --release might become more necessary

Comment on lines +944 to +949
--release <version>
resolve top-level version conflicts by specifying the release
version. This option is particularly useful during the migration
process when dealing with packages that have conflicting version
requirements. Specify the version that satisfies all package
version constraints.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is correct, but it describes one of the few side effects of using the --release option. The description should probably start with describing what the option does: --release Specify the release of Meteor to use (taken from the meteor run help).

@zodern
Copy link
Member

zodern commented Jan 11, 2024

There seem to be a few other commands that are also missing documentation for --release or only show it in the usage example, such as meteor test and meteor test-packages. I think most commands if not all of them have the --release option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document --release option on meteor publish command
5 participants