Re-enable TypeScript self-test #12934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest release of zodern:types is able to pull type declarations from a Meteor checkout, if it's being used, instead of only from the package repository (which may not contain the latest changes). This means that we should be able to re-enable the TypeScript test, which verifies that the TypeScript skeleton does, in fact, produce a project which passes type checking. (Re-enabling the test also picked up a few latent bugs in the type declarations, so fix those as well)
ebroder
force-pushed
the
typescript-tests
branch
from
b12ba90
to
a2a5342
Compare
|
Oh, and just to keep everything linked together, this should work now because zodern/meteor-types#8 has been merged and released. |
StorytellerCZ
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to tentatively try to re-enable this test, so that we can try and get a bit more stability in the TypeScript declarations. I am, admittedly, a little confused as to why I didn't run into zodern/meteor-types#10, but this did work in my local testing.
I think, for the record, that until we're a little more confident in the stability of these tests, it's fine to disable the test again if it runs into issues in CI (although I'd appreciate not wholesale reverting the PR, as the type changes should be correct independent of the test! 馃檪)
From the commit message:
cc @zodern @Grubba27 for awareness.