Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed flavor #166

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

Mixed flavor #166

wants to merge 27 commits into from

Conversation

iljarotar
Copy link
Contributor

@iljarotar iljarotar commented Jun 6, 2024

The mixed setup starts the mini-lab with 2 cumulus switches and one sonic switch to test migration from cumulus to sonic.

Migration depends on metal-stack/metal-api#566 and metal-stack/metalctl#262.

@iljarotar iljarotar requested a review from a team as a code owner June 6, 2024 11:17
@iljarotar iljarotar marked this pull request as draft June 6, 2024 11:18
@iljarotar iljarotar marked this pull request as ready for review June 13, 2024 13:12
@iljarotar iljarotar requested a review from majst01 June 13, 2024 13:12
@robertvolkmann
Copy link
Contributor

How I can test the migration from cumulus to SONiC with the new mixed flavor?

@majst01
Copy link
Contributor

majst01 commented Jun 14, 2024

How I can test the migration from cumulus to SONiC with the new mixed flavor?

Not yet, it is the foundation to be able to test that a mixed environment is able to put machines in waiting and successful allocation.

Migration is the next step where we need your support

@robertvolkmann
Copy link
Contributor

Is it possible to pre-register leaf01 and leaf02 with Cumulus OS in the metal API, and on startup of the leaves, have leaf02 perform the migration from Cumulus to SONiC?

@iljarotar
Copy link
Contributor Author

Is it possible to pre-register leaf01 and leaf02 with Cumulus OS in the metal API, and on startup of the leaves, have leaf02 perform the migration from Cumulus to SONiC?

I'm not sure if this will give us any insights. As I understand it, the metal-api doesn't ask for the previous configuration, when an existing switch registers again. It only checks the port names of the twin switch and makes sure they match with the new switch's port names. Maybe we can find a way to get closer to a real replace. Do you think this is possible in the mini-lab?

@iljarotar iljarotar self-assigned this Sep 16, 2024
@iljarotar iljarotar marked this pull request as draft September 16, 2024 12:45
@@ -83,9 +89,7 @@ partition: partition-bake
.PHONY: partition-bake
partition-bake: external_network
docker pull $(MINI_LAB_VM_IMAGE)
ifeq ($(MINI_LAB_FLAVOR),sonic)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ifneq ($(MINI_LAB_FLAVOR),cumulus)

@@ -85,6 +85,6 @@
retries: 60
delay: 3
until:
- lookup('metal', 'search', 'switch', api_url=metal_partition_metal_api_protocol+'://'+metal_partition_metal_api_addr+':'+metal_partition_metal_api_port|string+metal_partition_metal_api_basepath, api_hmac=metal_partition_metal_api_hmac_edit_key) | length == 2
- lookup('metal', 'search', 'switch', api_url=metal_partition_metal_api_protocol+'://'+metal_partition_metal_api_addr+':'+metal_partition_metal_api_port|string+metal_partition_metal_api_basepath, api_hmac=metal_partition_metal_api_hmac_edit_key) | length >= 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you count the number of leaves?

@@ -0,0 +1,3 @@
lo: 10.0.0.13
asn: 4200000013
metal_core_cidr: 10.0.1.255/{{ metal_core_cidr_mask }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes no sense. Why we need a different CIDR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants