Switch to tc mirrored to get rid of macvtap #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrigoriyMikhalkin What is your opinion? |
At the moment it's unclear if there's any benefits of using tc mirred vs macvtap. |
robertvolkmann
changed the title
|
Nice! I would assume that tc is also faster. Could you do a performance test/iperf btw. machines? |
|
I tested performance between machines and observed no differences between macvtap and tc-redirect. |
Gerrit91
changed the title
Gerrit91
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's essential to set the MAC address of the virtual network device equal to the corresponding lan device. Otherwise, only one of the machines can boot successfully via PXE, as already observed in PR #96.