-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to pending entities with BBIDs / Introducing Kysely #323
base: master
Are you sure you want to change the base?
Commits on Aug 12, 2024
-
refactor(imports): Adapt to the new schema where imports have BBIDs
Mostly column, property and table names had to be updated to follow the schema. A few other identifiers have been renamed as well for consistency, although this was not strictly necessary.
Configuration menu - View commit details
-
Copy full SHA for 3f8a095 - Browse repository at this point
Copy the full SHA 3f8a095View commit details
Commits on Aug 19, 2024
-
fix(imports): Remove unused property from function parameter type
It is never used and never passed, but causes a TS error.
Configuration menu - View commit details
-
Copy full SHA for 2578a5e - Browse repository at this point
Copy the full SHA 2578a5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39f0c43 - Browse repository at this point
Copy the full SHA 39f0c43View commit details -
refactor(imports): Avoid re-throwing our own errors
The error message is already specific enough, no need to make it longer.
Configuration menu - View commit details
-
Copy full SHA for 56df87e - Browse repository at this point
Copy the full SHA 56df87eView commit details -
fix(imports): Adapt deletion process to the new schema
In the end we of course want to reuse `bbid` and `data_id` of accepted entities instead of duplicating the data and deleting the original.
Configuration menu - View commit details
-
Copy full SHA for f1b2cf3 - Browse repository at this point
Copy the full SHA f1b2cf3View commit details
Commits on Sep 12, 2024
-
refactor(imports): Adapt approval to the new way imports are loaded
Also make `ImportMetadataT` more versatile/useful.
Configuration menu - View commit details
-
Copy full SHA for 532da04 - Browse repository at this point
Copy the full SHA 532da04View commit details
Commits on Sep 13, 2024
-
fix(imports): Remove raw SQL default value
It is not needed and it is causing a type error since the last commit.
Configuration menu - View commit details
-
Copy full SHA for b38e358 - Browse repository at this point
Copy the full SHA b38e358View commit details
Commits on Oct 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d1f5c48 - Browse repository at this point
Copy the full SHA d1f5c48View commit details -
chore(eslint): Drop comma-dangle rule
The rule to disallow trailing commas often forces you to pointlessly touch neighboring lines when you add or remove items. If we want to enforce consistent dangling commas, we should rather force them to always be present. But since our whole codebase follows this rule, it would be better to have a grace period to gradually add commas. metabrainz/bookbrainz-site@2fc11a2
Configuration menu - View commit details
-
Copy full SHA for 2909201 - Browse repository at this point
Copy the full SHA 2909201View commit details -
feat: Generate types for DB schema and setup kysely
Run the kysely-codegen task to regenerate the types. Don't forget to reformat the generated code to follow our linting rules. Since this is using DB introspection, you have to specify a DB connection string via the --url param or the DATABASE_URL env var: https://github.com/RobinBlomberg/kysely-codegen
Configuration menu - View commit details
-
Copy full SHA for 05446cd - Browse repository at this point
Copy the full SHA 05446cdView commit details -
feat(imports): Preserve BBID and DB rows of entities during approval
Rather than collecting all properties of the pending entity data and creating a new entity (with new BBID), we simply create an entity header and a revision which link to the existing data. This is a complete rewrite using Kysely instead of Bookshelf/Knex. The final loading of the entity model (for search indexing) is out of scope for this function and has been moved into bookbrainz-site.
Configuration menu - View commit details
-
Copy full SHA for fb8fd5a - Browse repository at this point
Copy the full SHA fb8fd5aView commit details
Commits on Nov 1, 2024
-
fix(imports): Mark
ParsedEdition.editionGroupBbid
as optionalFrom an older schema, there are still editions without edition group.
Configuration menu - View commit details
-
Copy full SHA for 1ee3d1a - Browse repository at this point
Copy the full SHA 1ee3d1aView commit details
Commits on Nov 3, 2024
-
fix(imports): Update recent import queries for new approval behavior
The `pending_entity_bbid` column is no longer set to NULL on approval, we have to additionally check for NULL in accepted_entity_bbid to find pending imports.
Configuration menu - View commit details
-
Copy full SHA for fdc7cbb - Browse repository at this point
Copy the full SHA fdc7cbbView commit details