Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metric V2] When joining a metric add its aggregation clause #42300

Merged
merged 2 commits into from
May 8, 2024
Merged

[Metric V2] When joining a metric add its aggregation clause #42300

merged 2 commits into from
May 8, 2024

Conversation

snoe
Copy link
Contributor

@snoe snoe commented May 6, 2024

Fixes #41932

@snoe snoe added the .Team/QueryProcessor :hammer_and_wrench: label May 6, 2024
@snoe snoe requested a review from a team May 6, 2024 22:10
@snoe snoe self-assigned this May 6, 2024
@snoe snoe requested a review from camsaul as a code owner May 6, 2024 22:10
@replay-io replay.io
Copy link

replay-io bot commented May 6, 2024 •
edited

Status Complete ↗︎
Commit 60ed947
Results
❌ 2 Failed
⚠️ 8 Flaky
✅ 2425 Passed

@ranquild ranquild requested a review from bshepherdson May 7, 2024 14:50
@snoe snoe closed this May 7, 2024
@snoe snoe force-pushed the metrics-v2-joining-metric-automatically-aggregates branch from b3061a0 to b717f80 Compare May 7, 2024 19:35
@snoe snoe reopened this May 7, 2024
ranquild
ranquild reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@ranquild ranquild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug - when adding a join, it adds an aggregation clause in a new stage and not the current one.
Before join:
Screenshot 2024-05-07 at 15 51 36

After join:
Screenshot 2024-05-07 at 15 51 45

@snoe snoe requested a review from ranquild May 7, 2024 21:20
@ranquild ranquild merged commit e508f6b into metrics-v2 May 8, 2024
103 of 108 checks passed
@ranquild ranquild deleted the metrics-v2-joining-metric-automatically-aggregates branch May 8, 2024 17:50
bshepherdson added a commit that referenced this pull request May 10, 2024
@bshepherdson
Revert "[Metric V2] When joining a metric add its aggregation clause (#…
eed2514 
…42300)"

This reverts commit e508f6b.
bshepherdson added a commit that referenced this pull request May 10, 2024
@bshepherdson
[Metrics] Remove support for joining on metrics
99a7185 
Effectively a revert of #42222 and #42300.

Fixes #42471.
@bshepherdson bshepherdson mentioned this pull request May 10, 2024
Merged
bshepherdson added a commit that referenced this pull request May 10, 2024
@bshepherdson
Revert "[Metric V2] When joining a metric add its aggregation clause (#…
a7ecfd6 
…42300)"

This reverts commit e508f6b.
bshepherdson added a commit that referenced this pull request May 10, 2024
@bshepherdson
[Metrics] Remove support for joining on metrics
454fc25 
Effectively a revert of #42222 and #42300.

Fixes #42471.
bshepherdson added a commit that referenced this pull request May 13, 2024
@bshepherdson
[Metrics] Remove support for joining on metrics (#42513)
d83fa07 
Effectively a revert of #42222 and #42300.

Fixes #42471.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshepherdson bshepherdson bshepherdson approved these changes

@ranquild ranquild ranquild approved these changes

@camsaul camsaul Awaiting requested review from camsaul

Assignees

@snoe snoe

Labels
.Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snoe @bshepherdson @ranquild