Aggregation picker changes for metrics #42053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…1935-aggregation-picker
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 02e38e4...f822c62.
|
ranquild
commented
May 2, 2024
| @@ -206,7 +206,7 @@ export const AccordionListCell = ({ | |||
| </div> | |||
| ); | |||
| } else if (type === "header-hidden") { | |||
| content = <div className={CS.my1} />; | |||
| content = <div className={cx({ [CS.my1]: itemIndex > 0 })} />; | |||
There was a problem hiding this comment.
Removes margin from the first empty header item
ranquild
commented
May 2, 2024
| @@ -95,25 +94,24 @@ export function AggregationPicker({ | |||
| const database = metadata.database(databaseId); | |||
| const canUseExpressions = database?.hasFeature("expression-aggregations"); | |||
|
|
|||
| if (operators.length > 0) { | |||
| if (metrics.length > 0) { | |||
ranquild
requested review from
uladzimirdev
and removed request for
a team and
uladzimirdev
ranquild
changed the title
ranquild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41935
Figma https://www.figma.com/file/17Z8b1uEdcrtpP8rVHaPAS/Metrics-v2?type=design&node-id=1697-3003&mode=design&t=rwgYnuNJy2ynVE8G-0
Changes:
Please note that if you remove the metric aggregation clause in the notebook editor for a question that uses a metric we start to add
Countby default in the summarize sidebar which looks strange/wrong. This is a separate issue .