Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook UI tweaks for metrics #42036

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Notebook UI tweaks for metrics #42036

merged 2 commits into from
Apr 30, 2024

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented Apr 30, 2024

Closes #41927

How to verify:

  • New -> Metric
  • Filter (optional) instead of Filter
  • Measure calculation instead of Summarize
  • No by separator in the summarize clause
Screenshot 2024-04-30 at 11 10 29

component: DataStep,
getColor: () => color("brand"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was previously done when there were issues with initializing colors in EE at startup. This issue has been fixed.

Copy link

replay-io bot commented Apr 30, 2024

Status Complete ↗︎
Commit 80606b0
Results
73 Failed
⚠️ 4 Flaky
2356 Passed

@ranquild ranquild added the no-backport Do not backport this PR to any branch label Apr 30, 2024
@ranquild ranquild merged commit 1cf4cb2 into metrics-v2 Apr 30, 2024
97 of 109 checks passed
@ranquild ranquild deleted the 41927-metric-ui-changes branch April 30, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryingComponents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants