Allow multiple values for string operators in the dashboard #42013
Conversation
nemanjaglumac
force-pushed
the
qc-text-filters-multi-values
branch
2 times, most recently
from
aa1b96f
to
22d6d47
Compare
|
nemanjaglumac
force-pushed
the
qc-text-filters-multi-values
branch
from
2bd8c46
to
0bce686
Compare
nemanjaglumac
changed the title
nemanjaglumac
changed the title
| cy.createQuestionAndDashboard({ | ||
| questionDetails: { | ||
| query: { "source-table": ORDERS_ID, limit: 5 }, | ||
| }, | ||
| cardDetails: { | ||
| size_x: 24, | ||
| size_y: 8, | ||
| }, | ||
| }).then(({ body: { id, dashboard_id } }) => { |
There was a problem hiding this comment.
Cypress was crashing so badly that I had to ease the load by creating a custom dashboard with the 5 row limit in its only card.
e2e/test/scenarios/dashboard-filters/shared/dashboard-filters-text-category.js
Outdated
Show resolved
Hide resolved
| export const DASHBOARD_TEXT_FILTERS = [ | ||
| { | ||
| operator: "Is", | ||
| single: true, |
There was a problem hiding this comment.
All operators except Is and Is not have tests for both single: true and single: false.
Any reason for Is and Is not not having tests with single: false?
There was a problem hiding this comment.
Is and Is not are using a helper that's too rigid and will not work with multiple values.
This is the consequence of trying to abstract too much.
I didn't want to change the underlying logic of that helper since it's very likely that these tests will have to be updated and/or broken down soon.
Co-authored-by: Kamil Mielnik <[email protected]>
|
@nemanjaglumac Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
This PR is a part of the milestone 2 of #41956.
It expands the multi-select filter capabilities for the dashboard filters to the "contains", "does not contain", "starts with" and "ends with" operators. This behavior was previously possible only for "is" and "is not" operators.
Testing
Resolves #41956