Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit node #3

Merged
merged 7 commits into from
Dec 20, 2024
Merged

Initial commit node #3

merged 7 commits into from
Dec 20, 2024
+867 −2

Conversation

albertoperdomo
Copy link
Member

@albertoperdomo albertoperdomo requested a review from a team November 19, 2024 19:16
heypoom
heypoom approved these changes Nov 20, 2024
View reviewed changes
node/index.js Outdated Show resolved Hide resolved
node/package.json Outdated Show resolved Hide resolved
heypoom
heypoom reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@heypoom heypoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like node_modules sneaked in there, let me remove it.

heypoom
heypoom approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@heypoom heypoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the accidental node_modules from git and added a gitignore, should be ok now

heypoom
heypoom approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@heypoom heypoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the accidental node_modules from git and added a gitignore, should be ok now

@albertoperdomo albertoperdomo merged commit 40e2b11 into main Dec 20, 2024
@albertoperdomo albertoperdomo deleted the add-node branch December 20, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heypoom heypoom heypoom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertoperdomo @heypoom