Python Flask example #1
Conversation
albertoperdomo
force-pushed
the
initial-commit-python
branch
from
c810c3a
to
1d2ea37
Compare
| app = Flask(__name__) | ||
|
|
||
| METABASE_SITE_URL = os.environ.get('METABASE_SITE_URL', 'http://localhost:3000') | ||
| METABASE_EMBEDDING_SECRET = os.environ.get('METABASE_EMBEDDING_SECRET') |
There was a problem hiding this comment.
Let's add a default value here. I ran the sample without reading the readme first. And it failed to run.
| METABASE_EMBEDDING_SECRET = os.environ.get('METABASE_EMBEDDING_SECRET') | |
| METABASE_EMBEDDING_SECRET = os.environ.get('METABASE_EMBEDDING_SECRET', 'ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff') |
this key is used in most of our example keys, so it should be safe.
There was a problem hiding this comment.
Does it work with that sample key? If not, it might be better to check and raise an error that the env key needs to be set before running, otherwise it will still be confusing. If we don't need to be fancy, changing get to os.environ['METABASE_EMBEDDING_SECRET'] would work as it will automatically raise a key error when not yet
There was a problem hiding this comment.
I think as @maxzheng says, adding a default value is just going to cover up the fact that the secret is missing. I prefer an explicit error.
There was a problem hiding this comment.
Cool. I'm on board with you guys. My gripe was that the error was quite cryptic. If os.environ['METABASE_EMBEDDING_SECRET'] throws better error that you need to set that key then let's do that.
| app = Flask(__name__) | ||
|
|
||
| METABASE_SITE_URL = os.environ.get('METABASE_SITE_URL', 'http://localhost:3000') | ||
| METABASE_EMBEDDING_SECRET = os.environ.get('METABASE_EMBEDDING_SECRET') |
There was a problem hiding this comment.
Does it work with that sample key? If not, it might be better to check and raise an error that the env key needs to be set before running, otherwise it will still be confusing. If we don't need to be fancy, changing get to os.environ['METABASE_EMBEDDING_SECRET'] would work as it will automatically raise a key error when not yet
|
|
||
| METABASE_SITE_URL = os.environ.get('METABASE_SITE_URL', 'http://localhost:3000') | ||
| METABASE_EMBEDDING_SECRET = os.environ.get('METABASE_EMBEDDING_SECRET') | ||
| METABASE_EMBED_DASHBOARD_ID = int(os.environ.get('METABASE_EMBED_DASHBOARD_ID', '1')) |
There was a problem hiding this comment.
Same for here as well. Default of 1 is ok if it should work, otherwise make it required instead like secret.
There was a problem hiding this comment.
We are now going to be seeding instances with an example dashboard, which I expect to have ID 1, although I don't know if it's 100% guaranteed.
Co-authored-by: Mahatthana (Kelvin) Nomsawadi <[email protected]>
Co-authored-by: Mahatthana (Kelvin) Nomsawadi <[email protected]>
Co-authored-by: Mahatthana (Kelvin) Nomsawadi <[email protected]>
No description provided.