Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop route execution on auth fail #26

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

iethree
Copy link
Contributor

@iethree iethree commented Feb 26, 2025

Previously, we would keep executing a route after we sent a failure response. This restructures the auth check to stop execution upon sending the error response.

@iethree iethree requested a review from wotbrew February 26, 2025 16:12
Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metabase-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 2:37pm

Copy link

@wotbrew wotbrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iethree iethree merged commit 9600fba into main Feb 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants