Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generation.py to add support for repetition penalty #733

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update generation.py to add support for repetition penalty #733

wants to merge 1 commit into from

Conversation

shounakb1
Copy link

Added support for repetition penalty in generate method.

@shounakb1
Update generation.py to add support for repetition penalty
c33ea3d 
Added support for repetition penalty in generate method.
@facebook-github-bot
Copy link

Hi @shounakb1!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2023
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@shounakb1
Copy link
Author

Adding support for temperature parameter to llama2, generate function.

@shounakb1 shounakb1 closed this Aug 28, 2023
@shounakb1 shounakb1 reopened this Aug 28, 2023
@msaroufim msaroufim added the needs-discussion If an issue fix has complexity and tradeoffs which requires further discussion. label Sep 1, 2023
@AurRod AurRod requested a review from javier-m September 6, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javier-m javier-m Awaiting requested review from javier-m

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. needs-discussion If an issue fix has complexity and tradeoffs which requires further discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shounakb1 @facebook-github-bot @msaroufim