Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download.sh to check for wget #467

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oliverisaac
Copy link

The script fails if you do not have wget installed. Fail early with a nice instruction if that is the case.

@facebook-github-bot
Copy link

Hi @oliverisaac!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2023
@ckxng ckxng self-assigned this Aug 31, 2023
@ckxng
Copy link

ckxng commented Aug 31, 2023

picking this up, I am reviewing several of the outstanding PRs for download.sh

@msaroufim msaroufim added the download-install Download and installation issues label Sep 1, 2023
@ckxng
Copy link

ckxng commented Oct 3, 2023

This PR needs to have its updates merged with main before it can proceed.

@ckxng ckxng removed their assignment Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. download-install Download and installation issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants