Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#patch); currentHolderCount in erc20 subgraph #2459

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

zjesko
Copy link
Contributor

@zjesko zjesko commented Jan 20, 2024

@nemani @dhruv-chauhan @melotik

Fix: currentHolderCount value turns negative for some tokens.

Eg. arbitrum (0x9e20461bc2c4c980f62f1B279D71734207a6A356)

Before fix:
Screenshot 2024-01-20 at 8 13 50 PM

After fix:
Screenshot 2024-01-20 at 9 00 18 PM

@zjesko zjesko changed the title Fix currentHolderCount in erc20 subgraph fix(#patch) currentHolderCount in erc20 subgraph Jan 21, 2024
@zjesko zjesko changed the title fix(#patch) currentHolderCount in erc20 subgraph fix(#patch); currentHolderCount in erc20 subgraph Jan 21, 2024
Copy link
Collaborator

@dhruv-chauhan dhruv-chauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of things,

  • could you please add the link to your hosted service deployment too for us to try out some queries.
  • There are some lint issues not introduced by your changes, but would be great if you could resolve those. And run prettier.
  • We update versions.subgraph here, but I see erc20 subgraph has separate deployments for each year, we'll take care of that. cc @melotik

subgraphs/erc20/src/mappings/token.ts Show resolved Hide resolved
@zjesko
Copy link
Contributor Author

zjesko commented Jan 22, 2024

Ran prettier for the erc20 folder

@melotik
Copy link
Contributor

melotik commented Jan 23, 2024

@zjesko I have to approve the workflow runs for the ci/cd to pass. But you can actually do this locally. Here are the commands for the failing checks:

  • Lint checker: npx eslint . and it only checks files that were changed in the PR
  • Build checker: you can see the issues it is running into using messari build erc20 -l

@dhruv-chauhan dhruv-chauhan merged commit 032220a into messari:master Jul 5, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants