Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor indentation issues and track dub lock file #3

Merged
merged 3 commits into from
Aug 31, 2020

Conversation

ljmf00
Copy link
Contributor

@ljmf00 ljmf00 commented Aug 31, 2020

I'm currently planing doing some extra unittests to cover some reported issues on D modules and found that I committed some spaces instead of tabs.

Also, dub.selections.json should be tracked by git as it is a lock file for versions described on dub.json. Although, we don't have any dependencies here nor doing version pinning and the dub.selections.json is almost empty, it's a good practice to have it there.

e.g.: See the official repository, https://github.com/dlang/dub

@ljmf00
Copy link
Contributor Author

ljmf00 commented Aug 31, 2020

@jpakkane tagging here, due to be a very calm project.

@jpakkane
Copy link
Member

Tabs are actually wrong, everything in Meson should be space-indented.

@ljmf00
Copy link
Contributor Author

ljmf00 commented Aug 31, 2020

Tabs are actually wrong, everything in Meson should be space-indented.

Ok, then I changed everything to spaces. I also added .editorconfig to match some settings from meson repository and *.d files with 4 spaces of indentation.

@ljmf00
Copy link
Contributor Author

ljmf00 commented Aug 31, 2020

When everything is good to go, after merge it, please consider creating a new version tag, matching the same syntax of D version tagging to trigger dub registry. It will publish the missing test3 subproject.

@jpakkane jpakkane merged commit b8e6fd3 into mesonbuild:master Aug 31, 2020
@jpakkane
Copy link
Member

What should be the correct name for the tag? The existing one seems to be v1.0.0 but everywhere on the Dub site it is called just 1.0.0. v1.1.0?

@ljmf00
Copy link
Contributor Author

ljmf00 commented Sep 1, 2020

You should tag with a v prefixed. Like you just said: v1.1.0, but on dub registry it will appear just 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants