Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added SNR lines for neighborInfo and direct routes in map #457

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jamon
Copy link

@jamon jamon commented Feb 22, 2025

Initial implementation of SNR route lines (see #456 for discussion)

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jamon Terrell seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@danditomaso
Copy link
Collaborator

danditomaso commented Feb 22, 2025

@jamon This is awesome, thanks for the submission.

@danditomaso
Copy link
Collaborator

I wanted to better understand where I would see the lines being drawn, I cloned your branch and opened it up. I didn't see anything connecting avatars on the Map, am I looking in the wrong place?

image

@jamon
Copy link
Author

jamon commented Feb 24, 2025

Directly attached nodes will be drawn immediately so long as your node has it's location set and you've heard from them recently.

Connections between other nodes are drawn when you see a NeighborInfo packet from them, but keep in mind that not all nodes have that turned on, and the node doesn't retain that information, so you'll only see the ones that come in while the client is connected.

We will be able to add traceroutes as a source of data in the future as well.

@danditomaso danditomaso self-requested a review February 24, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants