Bugfix/formwrapper fieldset #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SebFox2011 please add a Description detailing what was done in this PR |
Hunter275
added
enhancement
|
Sorry @Hunter275 I am not really famillar with github merge request. I have make some mistake. But for next i will enter a description. And i will start from master each time in my futurs mr |
Perfect, thank you for your contributions. I'll review these changes soon! |
danditomaso
reviewed
Jan 24, 2025
| "editor.formatOnSave": true, | ||
| "stm32-for-vscode.openOCDPath": false, | ||
| "stm32-for-vscode.makePath": false, | ||
| "stm32-for-vscode.armToolchainPath": false |
There was a problem hiding this comment.
Should this file be removed from the commit? These specific changes shouldnt be merged as every user shouldn't have these vscode project settings pushed upon them.
danditomaso
requested changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.