More blinkenlights work for Thinknode-m3 #8940
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances LED functionality for the ThinkNode-M3 device by adding message notification support using the green LED and implementing a critical battery warning with fast blinking behavior.
- Adds PIN_LED2 definition mapping to the green LED for external notification support
- Implements critical battery state (≤5% charge) with fast blink warning pattern
- Configures external notification module to use the green LED for message indicators
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| variants/nrf52840/ELECROW-ThinkNode-M3/variant.h | Defines PIN_LED2 as green_LED_PIN to enable external notification LED |
| src/modules/StatusLEDModule.h | Adds critical power state and timing variables for fast blink management |
| src/modules/StatusLEDModule.cpp | Implements critical battery detection (≤5%) and fast blink warning logic |
| src/mesh/NodeDB.cpp | Enables external notification module for ThinkNode-M3 using green LED |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the green LED as a message indicator, and adds a fast blink critical battery warning.