Ble banner #8902
Open
Ble banner #8902
+21
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR fixes the issue where the Bluetooth code frame doesn't disappear when pairing is complete. Not it no longer uses a frame, it instead shows the pairing code as a notification and disappears properly when connected device is paired. Tested on Heltec V3, T114, L1, Meshtiny, and RAK4631.
|
Contributor
|
My only issue with this change is that on smaller screens, the BLE pin is harder to see than the classic. Does the banner overlay support larger fonts? |
Contributor
|
Tested on MeshTiny and Wio Tracker L1 Pro - no issues here. @thebentern no we don't currently support larger fonts in the popups. |
Xaositek
approved these changes
Dec 9, 2025
Collaborator
Author
|
I do wonder if we could check if the bigger font would fit, and use it if it fits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old BLE code, use simpler banners