Gr language specific font #8808
Open
+2,193
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Greek language support (WIN1253 encoding) for InkHUD e-ink displays and OLED displays. The implementation includes new Greek font files, encoding handlers, and character mapping logic to enable proper rendering of Greek text on Heltec Mesh Pocket and similar devices.
Key Changes:
- Added three FreeSans fonts (6pt, 9pt, 12pt) with WIN1253 Greek character encoding
- Fixed critical encoding handler bug preventing 1-byte character crashes
- Implemented UTF-8 to WIN1253 character mapping for Greek alphabet
- Added OLED_GR font support with conditional compilation
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| variants/nrf52840/heltec_mesh_pocket/nicheGraphics.h | Switched font configuration from WIN1252 to WIN1253 for Greek support |
| src/graphics/niche/InkHUD/AppletFont.h | Added WINDOWS_1253 enum and Greek font includes/macros |
| src/graphics/niche/InkHUD/AppletFont.cpp | Implemented comprehensive WIN1253 encoding handler with Greek character mappings |
| src/graphics/niche/Fonts/FreeSans*_Win1253.h | Added three new Greek font files with glyph bitmaps (6pt, 9pt, 12pt) |
| src/graphics/fonts/OLEDDisplayFontsGR.h | New header declaring Greek OLED fonts with WIN1253 encoding |
| src/graphics/ScreenFonts.h | Added conditional compilation for Greek font selection |
| src/graphics/Screen.h | Implemented UTF-8 to WIN1253 character conversion logic for OLED displays |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Greek language support (WIN1253) for InkHUD displays
Adds WIN1253 Greek fonts for InkHUD e-ink displays, enabling Greek text rendering on Heltec Mesh Pocket and other InkHUD-compatible devices.
Changes:
Add FreeSans 6pt, 9pt, 12pt fonts with Greek characters (0xC0-0xFF)
Fix WIN1253 encoding handler in AppletFont.cpp (missing 1-byte char guard caused crash)
Configure Heltec Mesh Pocket variant to use WIN1253 fonts
Testing:
Verified Greek text display (e.g., "τεστ") renders correctly on Heltec Mesh Pocket InkHUD
🤝 Attestations