Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some minor additional options to userPrefs.jsonc #6137

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

karchf
Copy link

@karchf karchf commented Feb 24, 2025

  • Thank you for all the work y'all do on the meshtastic firmware. Just got into meshtastic a couple of months ago...and WHEW the changes are awesome.
  • First time contributing here, so apologies for me missing any obvious steps. I'll be posting in the discord shortly to ask for any feedback.
  • Added some options around GPS enablement and interval configuration to the userPrefs.jsonc
  • Also moved the timezone placeholder that maintained json validity for the file in absentia of other options to the end, so that editors of the userPrefs.jsonc file won't have to remember to add a comma to the tz field and remove one from a later field. Hopefully that saves some attempted build times.

Copy link
Contributor

@fifieldt fifieldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for taking the time to make your first patch :)

@karchf
Copy link
Author

karchf commented Feb 24, 2025

@fifieldt Thanks for the kind words! Any guidance on the "Merging is blocked" error? I don't think I have a merge commit, anything I need to do to resolve?

When I switch to classic merge experience, it goes away, so I don't really know if its an error.

@fifieldt
Copy link
Contributor

@karchf , you're likely just seeing those errors as you don't have merge rights to this repository. I do, so I can push the button. However, we normally leave these PRs open for a day or so so reviewers in different timezones can take a look. The Americans should be with us soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants