Port “Compass view” bottom sheet from Meshtastic-Apple PR #1504 #3896

jakevis · 2025-12-03T23:01:07Z

This ports the “Compass view” from Meshtastic-Apple PR pull/1504 (thanks @RCGV1) to Android. It keeps the phone’s location as origin and guides you to the selected node via a modal bottom sheet on Node Detail → Position → “Open Compass.”

What changed

Add localized strings for compass title/action, distance/bearing display, and sensor/permission/location warnings.
New providers: CompassHeadingProvider (rotation vector with accel+mag fallback) and PhoneLocationProvider (LocationManager flow with permission/provider state).
CompassViewModel/CompassUiState combine heading + phone location with the target node, computing distance, bearing, alignment, and elapsed “last position update.”
Compose CompassSheetContent: dial ~2/3 width, red north reference, black target bearing, larger cardinal labels + quarter/eighth ticks, distance/bearing rows, elapsed time, and warnings with CTAs (request permission, open location settings, request position).
Node Detail integration: Position section gets “Open Compass”; sheet starts/stops providers with visibility, caches target node, and includes “Request Position” inside the sheet.

Why
Per the iOS PR: adds a compass view to quickly navigate to a node—useful off-grid when locating a friend, dog, or tracker.

Testing

Built and ran on Android emulator (API 35); opened Node Detail → Position → Open Compass; verified sheet renders and warnings appear when sensors/permissions are missing. (No automated tests run in this PR.)

…n flows

CLAassistant · 2025-12-03T23:01:13Z

All committers have signed the CLA.

CLAassistant · 2025-12-03T23:01:13Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

jakevis · 2025-12-03T23:03:36Z

Screenshots of the changes:

DaneEvans · 2025-12-03T23:29:53Z

Why lines not a compass rose? And why are there 3 lines for a single bearing?

jakevis · 2025-12-04T17:00:04Z

Why lines not a compass rose? And why are there 3 lines for a single bearing?

Personal preference and re-using some old code I had from another project. Red is fixed line on the N marker; the thin under it is a heading line. Align the black lines and your walking directly to the node (accessibility feature mostly from the old project).

Orignal code and design I was playing with had support for multiple nodes on the rose (and that might a future PR - with a rose accessible from somewhere else). Totem Compass style - show where you stared nodes are both distance and direction from you.

For the moment; happy to drop the heading and red lines if folks prefer.

mdecourcy · 2025-12-04T17:15:41Z

Should there perhaps be a message displayed when the target node has a high degree of precision bits? So we don't send the users on a wild goosechase

jakevis · 2025-12-04T17:22:07Z

Should there perhaps be a message displayed when the target node has a high degree of precision bits? So we don't send the users on a wild goosechase

Let me see how hard it would be to tell the user the degree of error on the screen.. if its communicated somewhere..

jakevis · 2025-12-04T18:00:37Z

@DaneEvans @mdecourcy - ok simplified the rose and did implement an accuracy cone-

Data source: We use gps_accuracy (mm) and DOP (PDOP, or HDOP/VDOP fallback) from the node’s Position. If these are missing, uncertainty is “unknown.”
Visual: A translucent blue wedge around the bearing shows ±angular error (error radius vs. your distance). Close range + poor accuracy = wide wedge; good accuracy or long distance = narrow wedge.
Messaging (beneath the dial, next to distance/bearing):
- Known: “Estimated area: ±X (±Y°)” — rendered from compass_uncertainty.
- Unknown: “Estimated area: unknown accuracy” — rendered from compass_uncertainty_unknown.

I need to test this on some more physical devices though- only tested this in the emulator right now- but would love feedback.

…d text

jakevis · 2025-12-04T22:17:37Z

Converting to draft pending physical device testing of the error cone.

RCGV1 · 2025-12-07T07:11:29Z

@jakevis I made a pr into your fork repo to improve the view of the compass.

Improved the compass

jakevis · 2025-12-07T09:33:25Z

@jakevis I made a pr into your fork repo to improve the view of the compass.

Looks amazing! Thank you!

jamesarich · 2025-12-07T23:46:28Z

How y'all feeling about this, @jakevis @RCGV1 ?

Should we let copilot do a review pass?

RCGV1 · 2025-12-07T23:47:45Z

The only thing I have not fully tested is the uncertainty feature, also I did not figure out how to localize distance since right now it only shows km

jakevis · 2025-12-08T02:19:36Z

I have a todo item tomorrow to test this on a couple physical devices now I'm back from the weekend. I want to check the uncertainty cone some more- it's a tad hard to do in the emulator.

I have ran codex-max over it before I pushed to my branch; but yes - I would certainly say copilot should triple check 😀 - I can ask codex to take a pass at the localization as well.

- fix compass cone math by drawing in canvas space (0°=east) without double heading adjustment so wedge/dot rotate with device heading - normalize cone start angle to prevent wraparound artifacts and keep shading aligned - rebuild compass shading (filled wedge + edges) using marker color for consistent visual cues - include angle normalization helper for safer bearing math

jakevis

Ok a few things tested and everything seems to be functional.

I just pushed a fix for the cone alignment (wedge now tracks heading and target dot), and some changes around when to show time since update and accuracy. Localization of miles vs km also seems to function fine (based on your app settings).

Happy for copilot to have at it and see how we go.

jakevis · 2025-12-09T21:41:39Z

Signed-off-by: Jake Vis <[email protected]>

jamesarich · 2025-12-09T22:53:29Z

@jakevis you'll need to run ./gradlew spotlessApply detekt and clean up any errors

jakevis · 2025-12-09T23:29:08Z

🤦‍♂️ Will do, sorry about that.

jamesarich · 2025-12-09T23:31:48Z

🤦‍♂️ Will do, sorry about that.

no worries, it's a common gotcha most new contribs miss - so much so that we thought about scripting an action to remind folks when detekt or spotless fail on ci 😂

Copilot

Pull request overview

This PR ports the compass view feature from Meshtastic-Apple to Android, enabling users to navigate to mesh nodes using a visual compass interface with distance and bearing information. The implementation provides a modal bottom sheet accessible from the Node Detail screen's Position section.

Key Changes:

New compass providers for device heading (sensors) and phone location (GPS/Network)
CompassViewModel that combines heading, location, and target node data to compute bearing, distance, and alignment
Compose-based UI with rotating compass dial, cardinal markers, and uncertainty cone visualization
Integration with Node Detail screen via modal bottom sheet with proper permission handling

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`NodeDetailAction.kt`	Adds `OpenCompass` action to open compass sheet with target node and display units
`NodeDetailScreen.kt`	Adds action handler stub for compass (actual handling in NodeDetailList)
`NodeDetailList.kt`	Integrates compass sheet with lifecycle management, permission launchers, and ViewModel
`PositionSection.kt`	Adds "Open Compass" button when node has valid position
`CompassBottomSheet.kt`	Implements compass UI with rotating dial, warnings, distance/bearing display, and uncertainty visualization
`PhoneLocationProvider.kt`	Provides location updates via LocationManager with permission/provider state tracking
`CompassHeadingProvider.kt`	Provides device heading from rotation vector or accelerometer+magnetometer sensors
`CompassViewModel.kt`	Coordinates heading and location streams, computes bearing/distance, manages state
`CompassUiState.kt`	Defines render-ready state and warning enum for compass UI
`strings.xml`	Adds localized strings for compass title, actions, distances, bearings, and warnings

feature/node/src/main/kotlin/org/meshtastic/feature/node/component/CompassBottomSheet.kt

Copilot · 2025-12-09T23:59:08Z

feature/node/src/main/kotlin/org/meshtastic/feature/node/compass/CompassHeadingProvider.kt

+     *
+     * @param location Optional Location from the phone's location provider.
+     */
+    fun headingUpdates(location: Location? = null): Flow<HeadingState> = callbackFlow {


The headingUpdates function accepts a location parameter but never uses it because it's captured once at function creation time. However, the location needs to be continuously updated for accurate true north correction as the phone moves. Consider either removing the parameter and obtaining location dynamically, or restructuring to accept a Flow<Location?> that can be combined with sensor updates.

Had codex implement a suggested fix (on next push)

Copilot · 2025-12-09T23:59:09Z

feature/node/src/main/kotlin/org/meshtastic/feature/node/detail/NodeDetailList.kt

+        }
+    }
+
+    LaunchedEffect(showCompassSheet) { if (!showCompassSheet) compassViewModel?.stop() }


The LaunchedEffect that calls compassViewModel?.stop() should be placed inside the if (showCompassSheet && compassViewModel != null) block to ensure it's properly tied to the sheet's lifecycle. Currently, it's outside the conditional, which means the effect will run even when the sheet is never shown. Additionally, calling stop() when the sheet is dismissed should happen in the onDismiss callback to ensure immediate cleanup, not in LaunchedEffect which may have a delay.

feature/node/src/main/kotlin/org/meshtastic/feature/node/component/CompassBottomSheet.kt

…nent/CompassBottomSheet.kt Co-authored-by: Copilot <[email protected]> Signed-off-by: Jake Vis <[email protected]>

…ome ./gradlew detekt Now Passes

jakevis · 2025-12-12T07:48:54Z

@jakevis you'll need to run ./gradlew spotlessApply detekt and clean up any errors

Ok - we should be set here; and I think all the copilot fixes are implemented

Signed-off-by: Jake Vis <[email protected]>

feat(node/compass): add localized compass sheet with sensor + locatio…

022aa84

…n flows

Merge branch 'meshtastic:main' into main

dd232b4

Adjusting compass rose for simplicity

a564662

feat(compass): visualize positional uncertainty with accuracy cone an…

1284edf

…d text

jakevis marked this pull request as draft December 4, 2025 22:16

Improved the compass

ff57454

Merge pull request #1 from RCGV1/compass

a394406

Improved the compass

jakevis commented Dec 9, 2025

View reviewed changes

jakevis marked this pull request as ready for review December 9, 2025 21:36

Merge branch 'main' into main

f3b5231

Signed-off-by: Jake Vis <[email protected]>

jamesarich requested a review from Copilot December 9, 2025 22:31

Copilot started reviewing on behalf of jamesarich December 9, 2025 23:26 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

jamesarich added this to the 2.7.10 milestone Dec 10, 2025

jakevis and others added 5 commits December 11, 2025 22:08

Update feature/node/src/main/kotlin/org/meshtastic/feature/node/compo…

49d229a

…nent/CompassBottomSheet.kt Co-authored-by: Copilot <[email protected]> Signed-off-by: Jake Vis <[email protected]>

Update feature/node/src/main/kotlin/org/meshtastic/feature/node/compo…

9d76fba

…nent/CompassBottomSheet.kt Co-authored-by: Copilot <[email protected]> Signed-off-by: Jake Vis <[email protected]>

Update feature/node/src/main/kotlin/org/meshtastic/feature/node/compo…

99144c1

…nent/CompassBottomSheet.kt Co-authored-by: Copilot <[email protected]> Signed-off-by: Jake Vis <[email protected]>

Fixing co-pilot suggested changes

f260dd9

JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/H…

e8e3754

…ome ./gradlew detekt Now Passes

Merge branch 'main' into main

f8ec132

Signed-off-by: Jake Vis <[email protected]>

Uh oh!

Port “Compass view” bottom sheet from Meshtastic-Apple PR #1504 #3896

Are you sure you want to change the base?

Port “Compass view” bottom sheet from Meshtastic-Apple PR #1504 #3896

Conversation

jakevis commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Dec 3, 2025

Uh oh!

jakevis commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaneEvans commented Dec 3, 2025

Uh oh!

jakevis commented Dec 4, 2025

Uh oh!

mdecourcy commented Dec 4, 2025

Uh oh!

jakevis commented Dec 4, 2025

Uh oh!

jakevis commented Dec 4, 2025

Uh oh!

jakevis commented Dec 4, 2025

Uh oh!

RCGV1 commented Dec 7, 2025

Uh oh!

jakevis commented Dec 7, 2025

Uh oh!

jamesarich commented Dec 7, 2025

Uh oh!

RCGV1 commented Dec 7, 2025

Uh oh!

jakevis commented Dec 8, 2025

Uh oh!

jakevis left a comment

Choose a reason for hiding this comment

Uh oh!

jakevis commented Dec 9, 2025

Uh oh!

jamesarich commented Dec 9, 2025

Uh oh!

jakevis commented Dec 9, 2025

Uh oh!

jamesarich commented Dec 9, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

jakevis Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakevis commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jakevis commented Dec 3, 2025 •

edited

Loading

CLAassistant commented Dec 3, 2025 •

edited

Loading

jakevis commented Dec 3, 2025 •

edited

Loading