Fix #575: Replaced deprecated utils.Unmarshal and removed unused variables #579
Conversation
…ed variables Signed-off-by: Shivanshu Gupta <[email protected]>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
|
Thank you, @ShivanshuGupta07! |
|
@ShivanshuGupta07 merge conflicts |
config/provider/inmem.go
Outdated
| @@ -54,7 +54,8 @@ func (l *InMem) GetKey(key string) string { | |||
| func (l *InMem) GetObject(key string, result interface{}) error { | |||
| l.mutex.Lock() | |||
| defer l.mutex.Unlock() | |||
| return utils.Unmarshal(l.store[key], result) | |||
| //return utils.Unmarshal(l.store[key], result) | |||
There was a problem hiding this comment.
Con you remove this since it is no more used
utils/kubernetes/crd.go
Outdated
| @@ -35,7 +35,8 @@ func GetAllCustomResourcesInCluster(ctx context.Context, client rest.Interface) | |||
| } | |||
| var xcrd CRD | |||
| gvks := []*schema.GroupVersionResource{} | |||
| err = utils.Unmarshal(string(crdresult), &xcrd) | |||
| //err = utils.Unmarshal(string(crdresult), &xcrd) | |||
Signed-off-by: Shivanshu Gupta <[email protected]>
| @@ -35,7 +34,7 @@ func GetAllCustomResourcesInCluster(ctx context.Context, client rest.Interface) | |||
| } | |||
| var xcrd CRD | |||
| gvks := []*schema.GroupVersionResource{} | |||
| err = encoding.Unmarshal(crdresult, &xcrd) | |||
There was a problem hiding this comment.
encoding.Unmarshal is not deprecated, in fact recommended to be used.
It is the encoder recently added in Meshkit, which supports both json/yaml.
| @@ -55,7 +54,7 @@ func (l *InMem) GetKey(key string) string { | |||
| func (l *InMem) GetObject(key string, result interface{}) error { | |||
| l.mutex.Lock() | |||
| defer l.mutex.Unlock() | |||
| return encoding.Unmarshal([]byte(l.store[key]), result) | |||
|
@MUzairS15, so no changes are required now? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
vishalvivekm
removed
the
issue/stale
Description
This PR fixes #575 by replacing deprecated
utils.Unmarshalwithjson.Unmarshaland removing unused variables from the codebase.Notes for Reviewers
config/provider/inmem.goandutils/kubernetes/crd.go.utils.Unmarshaldoes not impact any other parts of the code that may rely on its specific behavior.Signed commits