Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Snackbar title on toggle of extensions #10927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed Snackbar title on toggle of extensions #10927

wants to merge 1 commit into from
+5 −2

Conversation

NAMANIND
Copy link

Notes for Reviewers

This PR fixes #10514

Signed commits

  • Yes, I signed my commits.

@welcome Welcome
Copy link

welcome bot commented May 11, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

@github-actions github-actions bot added the component/ui User Interface label May 11, 2024
@github-actions GitHub Actions
Copy link

@vishalvivekm
Copy link
Member

Hey @NAMANIND , let's discuss this on today's Meshery Dev meeting at 7:30 PM IST. I am adding this as an agenda item. Please Join https://meet.layer5.io/meshery if you are available during the meet.

sudhanshutech
sudhanshutech reviewed May 20, 2024
View reviewed changes
Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any screenshot or recording @NAMANIND ?

@NAMANIND
Copy link
Author

Hey @sudhanshutech here is the video

Previously

When enabling or disabling an extension, the message "Adapter processing" was displayed as a popup.

Currently

Upon enabling or disabling an extension, the name of the extension is properly displayed in the popup message, along with the appropriate "enable" or "disable" text.

Extensions._.Meshery.-.Google.Chrome.2024-05-20.16-57-43.mp4

MUzairS15
MUzairS15 reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@MUzairS15 MUzairS15 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A screenshot/recording depicitng the behaviour will be appreciated.
Oh you already did, nice.

ui/components/extensions/adapters/adapters.js
@@ -58,19 +58,22 @@ const Adapters = ({ updateProgress, classes }) => {
const handleAdapterDeployment = (payload, msg, selectedAdapter, adapterId) => {
updateProgress({ showProgress: true });

const isEnableAction = payload.status === 'ENABLED';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define (if it does not exist already) a constant inside constants.js and use that here as well on line 74 (you would have to use toLowerCase() or toUpperCase() depending on what you define the value for that constant)

@MUzairS15
Copy link
Contributor

More precisely, <name> adapter enabled/disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MUzairS15 MUzairS15 MUzairS15 left review comments

@sudhanshutech sudhanshutech sudhanshutech left review comments

@Yashsharma1911 Yashsharma1911 Awaiting requested review from Yashsharma1911

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component/ui User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Better snackbar title on toggle of extensions
4 participants
@NAMANIND @vishalvivekm @MUzairS15 @sudhanshutech