Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mesheryctl] support setting of provider with context create and system re/start command. #10921

Merged
merged 2 commits into from May 14, 2024

Conversation

MUzairS15
Copy link
Contributor

@MUzairS15 MUzairS15 commented May 10, 2024

Notes for Reviewers

This PR fixes #10907

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the component/mesheryctl CLI for Meshery label May 10, 2024
@MUzairS15 MUzairS15 force-pushed the MUzairS15/mesheryctl/provider branch from 1623cf0 to 3f532f1 Compare May 10, 2024 13:47
@MUzairS15 MUzairS15 requested a review from leecalcote May 10, 2024 13:48
Copy link

github-actions bot commented May 10, 2024

@@ -71,6 +71,9 @@ mesheryctl system start --reset

// Specify Platform to deploy Meshery to.
mesheryctl system start -p docker

// Specify Provider to use.
mesheryctl system start --provider Meshery
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the logic in this PR support multi-word providers like "CNCF Lab"? @hexxdump @alphaX86 can you confirm?

@leecalcote
Copy link
Member

This integrates smoothly with mesheryctl system provider and its subcommands, right?

@leecalcote
Copy link
Member

@alphaX86 is there a docs update needed to capture this flag?

@alphaX86
Copy link
Member

alphaX86 commented May 11, 2024

@alphaX86 is there a docs update needed to capture this flag?

Existing docs script captures the flags. So no update needed. They are present in Options section of each command doc page

Copy link
Member

Awesome. Thank you.

@leecalcote leecalcote merged commit 51fac8b into meshery:master May 14, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mesheryctl CLI for Meshery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mesheryctl] Enhance context and start commands with --provider flag
3 participants