Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created the UI for Brand pg #1719

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Created the UI for Brand pg #1719

wants to merge 32 commits into from

Conversation

psankhe28
Copy link
Contributor

@psankhe28 psankhe28 commented Apr 20, 2024 •
edited

Description

This PR fixes #1692

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Video:

brand-pg.webm

@psankhe28 psankhe28 marked this pull request as draft April 20, 2024 14:01
@netlify Netlify
Copy link

netlify bot commented Apr 20, 2024 •
edited

✅ Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 6d62af8
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6623cabaf2610f0008eb300a
😎 Deploy Preview https://deploy-preview-1719--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 20, 2024 •
edited

✅ Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit ac1ac42
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66538448c9368400086ac30d
😎 Deploy Preview https://deploy-preview-1719--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@psankhe28 psankhe28 marked this pull request as ready for review April 20, 2024 19:34
@psankhe28
Copy link
Contributor Author

@Rexford74, can you please review this?

@vishalvivekm
Copy link
Member

@psankhe28
Let's discuss this on websites call today. I've added this as an agenda item to the meeting minutes.
Meeting details: https://meet.layer5.io

@Rexford74 Rexford74 self-requested a review April 22, 2024 13:46
@Rexford74
Copy link

Rexford74 commented Apr 22, 2024 •
edited

Please be sure to drop in a message on slack when you've updated the PR so that we can review this and get it merged. Well done, @psankhe28.

Rexford74
Rexford74 suggested changes Apr 25, 2024
View reviewed changes
Copy link

@Rexford74 Rexford74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know when you have some time, Pratiksha. These changes can be rounded up and the PR merged before tomorrow's end. Just a few changes left. Please let me know what you decide. Thank you.

_sass/brand.scss Show resolved Hide resolved
@ritiksaxena124
Copy link
Contributor

Merge conflicts @psankhe28

@leecalcote
Copy link
Member

@Rexford74 ready for review.

@Rexford74
Copy link

Rexford74 commented May 4, 2024 •
edited

Hey, Pratiksha. Thank you your efforts on this so far. Just a little adjustments left to get this merged please if you will. I have highlighted the needed changes in a video for better understanding. Please let me know if this is clear or if you will require further clarification.
Thank you.
Video Link

@psankhe28
Copy link
Contributor Author

Hey, Pratiksha. Thank you your efforts on this so far. Just a little adjustments left to get this merged please if you will. I have highlighted the needed changes in a video for better understanding. Please let me know if this is clear or if you will require further clarification. Thank you. Video Link

The space is due to the layout which is used as a base for all the pages.

vishalvivekm
vishalvivekm requested changes May 5, 2024
View reviewed changes
Copy link
Member

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments..

_sass/brand.scss Outdated Show resolved Hide resolved
_sass/brand.scss Show resolved Hide resolved
ritiksaxena124
ritiksaxena124 reviewed May 10, 2024
View reviewed changes
collections/_pages/brand.html Outdated Show resolved Hide resolved
collections/_pages/brand.html Outdated Show resolved Hide resolved
@psankhe28 psankhe28 requested a review from Rexford74 May 18, 2024 16:51
@sudhanshutech
Copy link
Member

@psankhe28 will you share your progress in website meet if you don't have exam

@psankhe28
Copy link
Contributor Author

@psankhe28 will you share your progress in website meet if you don't have exam

I have already shown it twice and in the last meet it was decided to merge but it is not merged yet.
I have my exams till 10 June so I won't be able to join.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rexford74 Rexford74 Awaiting requested review from Rexford74

@ritiksaxena124 ritiksaxena124 Awaiting requested review from ritiksaxena124

@vishalvivekm vishalvivekm Awaiting requested review from vishalvivekm

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meshery Brand Page Update [Website]
6 participants
@psankhe28 @vishalvivekm @Rexford74 @ritiksaxena124 @leecalcote @sudhanshutech