-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: modal issues #1705
Fix: modal issues #1705
Conversation
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Abhhishek Mamgain <[email protected]>
@ritiksaxena124 Kindly review the PR. |
@abhishekmmgn Can you please point to the issue you were working on ? |
Hey @abhishekmmgn let's discuss this on today's website meet if you are available. I have added it as an agenda item |
We can merge the PR now if it can. There are a lot of commits on top of it now, so I get merge conflicts when pushing the changes. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@iArchitSharma review, please. |
Signed-off-by: Archit Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
data-snapshot-light="https://raw.githubusercontent.com/layer5labs/meshery-extensions-packages/master/action-assets/design-assets/{{pattern.patternId}}-light.png" | ||
data-snapshot-dark="https://raw.githubusercontent.com/layer5labs/meshery-extensions-packages/master/action-assets/design-assets/{{pattern.patternId}}-dark.png" | ||
src="https://raw.githubusercontent.com/layer5labs/meshery-extensions-packages/master/action-assets/design-assets/{{pattern.patternId}}-dark.png" | ||
onerror="this.src='/assets/images/patterns/service-mesh.svg'" loading="lazy" onclick="toggleFullScreenImage('{{ pattern.patternId }}')" /> | ||
{%endif%} | ||
onerror="this.src='{{site.baseurl}}/assets/images/logos/service-mesh-pattern.svg', this.style.width = '50%'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR fixes #
Notes for Reviewers
List of changes/fixes:
Added spacing between filters and the catalog
z index and top margin of the help modal.
Read more shows only if there is more content
General spacing
General UI issues
Added mini card (related pattern card) on viewport width ~600 - 1150
changed ...read more to Read more
Added button to meshery.io/extensions card
Converted title to link and changed external link icon to internal
Changed the service mesh-looking image to a service-mesh-pattern image
Add related patterns on small-width
The gap in the catalog
Signed commits