Fix: modal issues #1705
Fix: modal issues #1705
Conversation
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Abhhishek Mamgain <[email protected]>
|
@ritiksaxena124 Kindly review the PR. |
abhishekmmgn
requested review from
leecalcote and
sudhanshutech
and removed request for
leecalcote
|
@abhishekmmgn Can you please point to the issue you were working on ? |
|
The top spacing for the "Extension" title is not responsive. It was working correctly previously. |
|
Hey @abhishekmmgn let's discuss this on today's website meet if you are available. I have added it as an agenda item |
|
We can merge the PR now if it can. There are a lot of commits on top of it now, so I get merge conflicts when pushing the changes. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
|
@iArchitSharma review, please. |
stale
bot
removed
the
issue/stale
Signed-off-by: Archit Sharma <[email protected]>
| data-snapshot-light="https://raw.githubusercontent.com/layer5labs/meshery-extensions-packages/master/action-assets/design-assets/{{pattern.patternId}}-light.png" | ||
| data-snapshot-dark="https://raw.githubusercontent.com/layer5labs/meshery-extensions-packages/master/action-assets/design-assets/{{pattern.patternId}}-dark.png" | ||
| src="https://raw.githubusercontent.com/layer5labs/meshery-extensions-packages/master/action-assets/design-assets/{{pattern.patternId}}-dark.png" | ||
| onerror="this.src='/assets/images/patterns/service-mesh.svg'" loading="lazy" onclick="toggleFullScreenImage('{{ pattern.patternId }}')" /> | ||
| {%endif%} | ||
| onerror="this.src='{{site.baseurl}}/assets/images/logos/service-mesh-pattern.svg', this.style.width = '50%'" |
Description
This PR fixes #
Notes for Reviewers
List of changes/fixes:
Added spacing between filters and the catalog
z index and top margin of the help modal.
Read more shows only if there is more content
General spacing
General UI issues
Added mini card (related pattern card) on viewport width ~600 - 1150
changed ...read more to Read more
Added button to meshery.io/extensions card
Converted title to link and changed external link icon to internal
Changed the service mesh-looking image to a service-mesh-pattern image
Add related patterns on small-width
The gap in the catalog
Signed commits