Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Consolidate duplicative and unused CSS #896

Open
leecalcote opened this issue Nov 3, 2022 · 19 comments · May be fixed by #1898
Open

Website: Consolidate duplicative and unused CSS #896

leecalcote opened this issue Nov 3, 2022 · 19 comments · May be fixed by #1898
Assignees
Labels
area/website framework/jekyll Issues or pull requests that use Jekyll good first issue Good for newcomers help wanted Extra attention is needed issue/willfix This issue will be worked on kind/enhancement New feature or request language/css

Comments

@leecalcote
Copy link
Member

Current Behavior
This site has much unused CSS and some overlapping CSS.

Desired Behavior
Use of SASS is preferred. Ideally, most of the CSS (by line count) is removed from the site. This can be done piecemeal over multiple PRs.


Contributor Guides and Resources

@leecalcote leecalcote added kind/enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed framework/jekyll Issues or pull requests that use Jekyll area/website language/css labels Nov 3, 2022
@tinniaru3005
Copy link
Member

tinniaru3005 commented Nov 6, 2022

Hey @leecalcote, I can work on this. Can you please explain what you mean by multiple PRs?

@leecalcote
Copy link
Member Author

@tinniaru3005 this effort doesn't have to be completed in one shot.

@leecalcote
Copy link
Member Author

@tinniaru3005 does this make sense?

@tinniaru3005
Copy link
Member

@tinniaru3005 does this make sense?

Ya, it does. Should I get started with solving it? Is there any specification on breaking up the task that I should follow?

@stale
Copy link

stale bot commented Dec 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Dec 17, 2022
@leecalcote leecalcote added issue/willfix This issue will be worked on issue/wontfix This will not be worked on and removed issue/stale Issue has not had any activity for an extended period of time labels Dec 17, 2022
@arun-kushwaha04
Copy link

Hey @leecalcote can i take this task ?

@leecalcote leecalcote removed the issue/wontfix This will not be worked on label Jan 21, 2023
@leecalcote
Copy link
Member Author

Thanks, @arun-kushwaha04

@ashutosh887
Copy link

@leecalcote Let me try this one now

@ashutosh887
Copy link

Thanks @leecalcote

@DarrenDsouza7273
Copy link
Contributor

@ashutosh887 please update

@Pranjal7852
Copy link

is the issue solved or anyone is working on it?

@DarrenDsouza7273
Copy link
Contributor

@Pranjal7852 theres been no updates from @ashutosh887 so i guess he might be working on it

@Ghat0tkach
Copy link
Member

I already have some experience in Sass architecture , and upon looking at the repo i found the basic architecture missing as mentioned in
https://sass-guidelin.es/#architecture , the 7-1 pattern
Basically, we have all our partials stuffed into 7 different folders, and a single file at the root level (usually named main.scss) which imports them all to be compiled into a CSS stylesheet.

base/
components/
layout/
pages/
themes/
abstracts/
vendors/

@Savio629
Copy link
Contributor

Savio629 commented Jun 2, 2023

@Pranjal7852 do you still want to work on this issue or let @Ghat0tkach take up this issue?

@Pranjal7852
Copy link

I still working on this issue @Savio629
cheers

@thisiskaransgit
Copy link
Contributor

@Pranjal7852, since we haven't heard back from @Pranjal7852, Reassigning this issue to myself

@Dananjay996
Copy link

@sudhanshutech Can I assign myself this issue?

@THEBOSS0369
Copy link

Hey @leecalcote ! if this issue is still open would like to work on it.

@THEBOSS0369
Copy link

THEBOSS0369 commented Aug 21, 2024

Hey @leecalcote ! I have added PR for this issue here #1880 by using this method we can easily remove unused CSS from the codebase without checking every file manually.

@THEBOSS0369 THEBOSS0369 linked a pull request Sep 13, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website framework/jekyll Issues or pull requests that use Jekyll good first issue Good for newcomers help wanted Extra attention is needed issue/willfix This issue will be worked on kind/enhancement New feature or request language/css
Projects
None yet