Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated params #184

Merged
merged 4 commits into from
Jan 27, 2021
Merged

Updated params #184

merged 4 commits into from
Jan 27, 2021

Conversation

dhruv0000
Copy link
Member

@dhruv0000 dhruv0000 commented Jan 26, 2021

Signed-off-by: dhruv0000 [email protected]
Will be Open once the meshery-adaptor-library PR #33 is tested for all the adaptors.
Description
This PR fixes of changes in #31 and #33

Notes for Reviewers

  • Added "type" in MeshSpecDefaults
  • Updated common.SmiConformanceOperation to use RunSMITest
  • Removed redundant SMI Test successful Event notification
  • Updated go.mod to point to master branch of meshkit and meshery-adaptor-library

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: dhruv0000 <[email protected]>
@welcome
Copy link

welcome bot commented Jan 26, 2021

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Signed-off-by: dhruv0000 <[email protected]>
Signed-off-by: dhruv0000 <[email protected]>
Signed-off-by: dhruv0000 <[email protected]>
@dhruv0000 dhruv0000 marked this pull request as ready for review January 27, 2021 22:06
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@leecalcote leecalcote merged commit 5fc8e2c into meshery:master Jan 27, 2021
@welcome
Copy link

welcome bot commented Jan 27, 2021

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants