Bump go version and remove no useful tracing code #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #125
Notes for Reviewers
v1.21v0.6.77go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpctov0.45.0github.com/grpc-ecosystem/go-grpc-middleware/v2to the stable versionv2.0.1And remove the no useful tracing features. It imported
go.opentelemetry.iodifferent version withgo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc. And the one of the reasons here is thatgo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpcdidn't update thego.opentelemetry.ioversion yet. And there is no any other adapters are using tracing feature. So, removing it.Removing
tracingfeature can also cause breaking change ofgrpcStart function.Signed commits