Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the slack.yml file #129

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Conversation

captain-Akshay
Copy link
Contributor

Description

This PR fixes #127

Desired State

Under GitHub Actions of this repository "Slack Notify on Star" job is failing for which Slack.yaml is to be Updated.

Notes for Reviewers

To fix this issue, updated the code of slack.yaml

Signed commits

  • Yes, I signed my commits.

Signed-off-by: captain-Akshay <[email protected]>
@captain-Akshay
Copy link
Contributor Author

@saurabh100ni done!
would love to be reviewed!

@Aisuko Aisuko self-requested a review October 25, 2023 03:25
@Aisuko Aisuko self-assigned this Oct 25, 2023
@Aisuko Aisuko added the area/ci Continuous integration | Build and release label Oct 25, 2023
Copy link
Member

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @captain-Akshay thanks for your contribution. How can I make sure it is work well now?

@captain-Akshay
Copy link
Contributor Author

Hi @captain-Akshay thanks for your contribution. How can I make sure it is work well now?

Ah it was just copying and pasting if the keys are there in github action then i dont except anything to go wrong 😅 @Aisuko

Copy link
Member

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@Aisuko Aisuko merged commit 9bbc51c into meshery:master Oct 28, 2023
3 checks passed
@Aisuko
Copy link
Member

Aisuko commented Oct 28, 2023

@captain-Akshay thank you. Here we merge this one first. Please keep following the PR and make sure the effect was made by this PR.

@captain-Akshay
Copy link
Contributor Author

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to fix error in "Slack Notify on Star" Job under GitHub Actions
2 participants