Add collections migrations between instances #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davert0
changed the title
|
Will do a detailed review asap. Thanks. |
mertsalik
requested changes
Nov 8, 2022
There was a problem hiding this comment.
I have walked through this PR. Thanks for the effort.
Could you please remove the specific file names from the gitignore ( i couldn't understand the purpose ), and skip the deletion of get_by_collection method which is used by some command scripts ( someone might be using those scripts, that change will broke them ).
Thanks.
| @@ -95,3 +95,6 @@ gen | |||
| # virtual environment | |||
| venv/ | |||
| .venv/ | |||
|
|
|||
| collab.json | |||
| password.txt | |||
There was a problem hiding this comment.
Do we really need those two specific files to be ignored ?
| ) | ||
| Resource.validate_response(response=resp) | ||
| return resp.json() | ||
|
|
||
| def get_by_collection(self, collection_slug): |
There was a problem hiding this comment.
This is used by the helper scripts:
- exporter.py
- migrator.py
although they are a bit old, i suggest to keep this method.
metabasepy/client.py
Outdated
| @@ -304,23 +421,36 @@ def get(self, collection_id=None, archived=False): | |||
| url=url, | |||
| headers=self.prepare_headers(), | |||
| verify=self.verify, | |||
| proxies=self.proxies | |||
| proxies=self.proxies, | |||
There was a problem hiding this comment.
Thanks for overall styling & format. ✌️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have added full collection migration between different metabase instances including dashboards visualization, any comments would be appreciated