Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Architecture/fix] Throw explicit error for invalid configuration causing overlapping nodes #6176

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

NicolasNewman
Copy link
Collaborator

@NicolasNewman NicolasNewman commented Jan 9, 2025

📑 Summary

To avoid user confusion, Architecture diagrams now explicitly throw an error if two services attempt to connect to the same side of another service.

Resolves #6120

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 6fce403

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 6fce403
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/679487cd8ae3cf0008639195
😎 Deploy Preview https://deploy-preview-6176--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jan 9, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6176
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6176
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6176
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6176

commit: 6fce403

Copy link

argos-ci bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Awaiting the start of a new Argos build…

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 4.47%. Comparing base (d27d4ab) to head (6fce403).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
...ermaid/src/diagrams/architecture/architectureDb.ts 0.00% 16 Missing ⚠️
...aid/src/diagrams/architecture/architectureTypes.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6176      +/-   ##
==========================================
- Coverage     4.47%   4.47%   -0.01%     
==========================================
  Files          385     385              
  Lines        54190   54207      +17     
  Branches       598     598              
==========================================
  Hits          2425    2425              
- Misses       51765   51782      +17     
Flag Coverage Δ
unit 4.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...aid/src/diagrams/architecture/architectureTypes.ts 0.00% <0.00%> (ø)
...ermaid/src/diagrams/architecture/architectureDb.ts 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Architecture diagram: Nodes overlap in same group
2 participants